Fix Policy.launch to be compatible with new ForgeActor.launch API #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Jack-Khuu
approved these changes
Sep 24, 2025
casteryh
approved these changes
Sep 24, 2025
| ) -> "Policy": | ||
| # Note - get_proc_mesh will set MASTER_ADDR, MASTER_PORT and CUDA_VISIBLE_DEVICES | ||
| # automatically. | ||
| process_config: ProcessConfig = ProcessConfig( |
There was a problem hiding this comment.
no action required.
just curious why this wasn't an issue before? is it because we got rid of process_config in the new config format?
There was a problem hiding this comment.
Policy.launch inherited from ForgeActor.launch. This wasn’t an issue before because ForgeActor.launch required process_config. After the PR #195, ForgeActor.launch no longer takes a process_config and constructs a default process_config, but Policy.launch still required it, which is a mismatch.
This was referenced Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
Policy.launchto match the newForgeActor.launchAPI, removing theprocess_configargument and construct it inside oflaunch.Specifically fixed the error
Test
cc @casteryh @vidhyav @felipemello1